RESOLVED FIXED 96720
[Chromium] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing 
https://bugs.webkit.org/show_bug.cgi?id=96720
Summary [Chromium] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserv...
Kent Tamura
Reported 2012-09-13 20:15:09 PDT
The following layout test is failing on Chromium-Mac and Chromium-Windows fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html Probable cause: Unknown http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=time-multiple-fields-preserve-value-after-history-back.html
Attachments
Patch (27.76 KB, patch)
2012-11-30 01:38 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.75 KB, patch)
2012-11-30 02:05 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-28 03:14:30 PST
*** Bug 103152 has been marked as a duplicate of this bug. ***
Kent Tamura
Comment 2 2012-11-28 03:16:12 PST
All of fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html are flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=preserve-value-after-history
Kent Tamura
Comment 3 2012-11-30 01:38:51 PST
Created attachment 176922 [details] Patch
Kentaro Hara
Comment 4 2012-11-30 01:46:18 PST
Comment on attachment 176922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176922&action=review > LayoutTests/ChangeLog:3 > + [Chroimum] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing Typo: Chromium > LayoutTests/ChangeLog:12 > + Make the outer switch a function to be called window.onload, and stop to >> Make the outer switch a function to be called window.onload Is this necessary to fix the failure? (Why?) Or is this just a refactoring?
Kent Tamura
Comment 5 2012-11-30 01:54:12 PST
(In reply to comment #4) > > LayoutTests/ChangeLog:12 > > + Make the outer switch a function to be called window.onload, and stop to > > >> Make the outer switch a function to be called window.onload > > Is this necessary to fix the failure? (Why?) Or is this just a refactoring? Yes. ChangeLog explains the reason at the previous paragraph.
Kentaro Hara
Comment 6 2012-11-30 02:02:56 PST
Comment on attachment 176922 [details] Patch Makes sense. (I was misreading js-test-post.js with js-test-pre.js.)
Kent Tamura
Comment 7 2012-11-30 02:05:14 PST
Created attachment 176927 [details] Patch for landing Fix summary
WebKit Review Bot
Comment 8 2012-11-30 02:33:23 PST
Comment on attachment 176927 [details] Patch for landing Clearing flags on attachment: 176927 Committed r136219: <http://trac.webkit.org/changeset/136219>
WebKit Review Bot
Comment 9 2012-11-30 02:33:27 PST
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 10 2012-12-05 00:50:43 PST
r136219 fixed the major flakiness. However they still timed out and I marked them [ Slow ] in http://trac.webkit.org/changeset/136333 . The slowness should be addressed in Bug 104094.
Note You need to log in before you can comment on or make changes to this bug.