Bug 96715

Summary: Remove Blob.webkitSlice
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: kinuko, mjs, ojan, syoichi, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-09-13 18:11:47 PDT
Remove Blob.webkitSlice
Attachments
Patch (6.36 KB, patch)
2012-09-13 18:13 PDT, Adam Barth
no flags
Adam Barth
Comment 1 2012-09-13 18:13:49 PDT
Darin Fisher (:fishd, Google)
Comment 2 2012-09-13 22:28:46 PDT
Comment on attachment 164019 [details] Patch It's not totally clear to me from those metrics that we won't break some sites with this change. Let's give it a try, but it would probably be good to delay this until after the Chrome 23 branch (which is cut next Tuesday IIRC).
Adam Barth
Comment 3 2012-09-14 00:14:28 PDT
Yeah, I'm not sure how to interpret the metrics either. We'll know better after we try a few of these and see where we run into problems.
Adam Barth
Comment 4 2012-09-19 17:57:58 PDT
Comment on attachment 164019 [details] Patch Fingers crossed.
WebKit Review Bot
Comment 5 2012-09-19 18:14:56 PDT
Comment on attachment 164019 [details] Patch Rejecting attachment 164019 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: static-dashboards/flakiness_dashboard_unittests.js Failed to merge in the changes. Patch failed at 0001 update flakiness dashboard after cutover to new test expectations syntax When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13944006
WebKit Review Bot
Comment 6 2012-09-19 18:40:40 PDT
Comment on attachment 164019 [details] Patch Clearing flags on attachment: 164019 Committed r129082: <http://trac.webkit.org/changeset/129082>
WebKit Review Bot
Comment 7 2012-09-19 18:40:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.