Bug 96715 – Remove Blob.webkitSlice

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Remove Blob.webkitSlice

[Adam Barth]

Created attachment 164019 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 164019 [details]
Patch

It's not totally clear to me from those metrics that we won't break some sites with this change.  Let's give it a try, but it would probably be good to delay this until after the Chrome 23 branch (which is cut next Tuesday IIRC).

[Adam Barth]

Yeah, I'm not sure how to interpret the metrics either.  We'll know better after we try a few of these and see where we run into problems.

[Adam Barth]

Comment on attachment 164019 [details]
Patch

Fingers crossed.

[WebKit Review Bot]

Comment on attachment 164019 [details]
Patch

Rejecting attachment 164019 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
static-dashboards/flakiness_dashboard_unittests.js
Failed to merge in the changes.
Patch failed at 0001 update flakiness dashboard after cutover to new test expectations syntax

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13944006

[WebKit Review Bot]

Comment on attachment 164019 [details]
Patch

Clearing flags on attachment: 164019

Committed r129082: <http://trac.webkit.org/changeset/129082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.