Bug 96715 - Remove Blob.webkitSlice
Summary: Remove Blob.webkitSlice
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Keywords: WebExposed
Depends on:
Reported: 2012-09-13 18:11 PDT by Adam Barth
Modified: 2012-09-19 18:40 PDT (History)
5 users (show)

See Also:

Patch (6.36 KB, patch)
2012-09-13 18:13 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-13 18:11:47 PDT
Remove Blob.webkitSlice
Comment 1 Adam Barth 2012-09-13 18:13:49 PDT
Created attachment 164019 [details]
Comment 2 Darin Fisher (:fishd, Google) 2012-09-13 22:28:46 PDT
Comment on attachment 164019 [details]

It's not totally clear to me from those metrics that we won't break some sites with this change.  Let's give it a try, but it would probably be good to delay this until after the Chrome 23 branch (which is cut next Tuesday IIRC).
Comment 3 Adam Barth 2012-09-14 00:14:28 PDT
Yeah, I'm not sure how to interpret the metrics either.  We'll know better after we try a few of these and see where we run into problems.
Comment 4 Adam Barth 2012-09-19 17:57:58 PDT
Comment on attachment 164019 [details]

Fingers crossed.
Comment 5 WebKit Review Bot 2012-09-19 18:14:56 PDT
Comment on attachment 164019 [details]

Rejecting attachment 164019 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Failed to merge in the changes.
Patch failed at 0001 update flakiness dashboard after cutover to new test expectations syntax

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13944006
Comment 6 WebKit Review Bot 2012-09-19 18:40:40 PDT
Comment on attachment 164019 [details]

Clearing flags on attachment: 164019

Committed r129082: <http://trac.webkit.org/changeset/129082>
Comment 7 WebKit Review Bot 2012-09-19 18:40:44 PDT
All reviewed patches have been landed.  Closing bug.