Bug 96679

Summary: Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Hans Muller 2012-09-13 12:07:08 PDT
The following comment from RenderStyle.h is wrong, "vertical-rl" should be vertical-lr:

    // Bottom of the line occurs earlier in the block; modes vertical-rl or horizontal-bt.
    bool isFlippedLinesWritingMode() const { return writingMode() == LeftToRightWritingMode || writingMode() == BottomToTopWritingMode; }

The semantics of the inline functions in WritingMode.h are a little bit difficult to divine, at least they were for me. The functions are essentially duplicated in RenderStyle.h, where they appear with comments.  The RenderStyle.h versions should be defined int terms of the inlines defined in WritingMode.h, and the handy comments could be relocated to WritingMode.h.
Comment 1 Hans Muller 2012-09-13 12:19:49 PDT
Created attachment 163933 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-13 14:20:49 PDT
Comment on attachment 163933 [details]
Patch

Clearing flags on attachment: 163933

Committed r128508: <http://trac.webkit.org/changeset/128508>
Comment 3 WebKit Review Bot 2012-09-13 14:20:52 PDT
All reviewed patches have been landed.  Closing bug.