Bug 96668

Summary: [CSS Shaders] Enable anti-aliasing on the FECustomFilter
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, vhardy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch V1
dino: review+
Patch for landing none

Alexandru Chiculita
Reported 2012-09-13 10:40:22 PDT
FECustomFilter needs anti-aliasing, otherwise the result has stair-case effect on the margins.
Attachments
Patch V1 (11.72 KB, patch)
2012-09-13 17:22 PDT, Alexandru Chiculita 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (11.99 KB, patch)
2012-09-14 12:51 PDT, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1 2012-09-13 17:22:12 PDT
Created attachment 164007 [details] Patch V1 This patch will fail to apply because it needs the refactor in https://bugs.webkit.org/show_bug.cgi?id=96579 .
Dean Jackson
Comment 2 2012-09-14 09:29:22 PDT
Comment on attachment 164007 [details] Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=164007&action=review > Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:351 > + int sampleCount = std::min(4, maxSampleCount); While it's only used here, I think we should define a MAX_CUSTOM_SAMPLES or something at the top of the file. > Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:362 > + m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFrameBuffer); > + > + m_context->bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_multisampleRenderBuffer); nit: remove blank line
Alexandru Chiculita
Comment 3 2012-09-14 12:51:00 PDT
Created attachment 164210 [details] Patch for landing
Alexandru Chiculita
Comment 4 2012-09-14 12:53:36 PDT
Comment on attachment 164210 [details] Patch for landing The patch cannot apply because of the diff in the changelog :)
Alexandru Chiculita
Comment 5 2012-09-14 13:08:28 PDT
Landed in http://trac.webkit.org/changeset/128646 .
Note You need to log in before you can comment on or make changes to this bug.