Bug 96666

Summary: [chromium] alter fling animation parameters.
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: PlatformAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: anicolao, enne, jamesr, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Robert Kroeger
Reported 2012-09-13 10:12:10 PDT
Extend the tail of fling animations based on user feedback.
Attachments
Patch (2.40 KB, patch)
2012-09-13 10:22 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (1.94 KB, patch)
2012-09-13 12:33 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2012-09-13 12:58 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-09-13 10:22:41 PDT
Created attachment 163901 [details] Patch
Robert Kroeger
Comment 2 2012-09-13 10:23:30 PDT
enne@ Could you review please?
Robert Kroeger
Comment 3 2012-09-13 10:23:31 PDT
enne@ Could you review please?
W. James MacLean
Comment 4 2012-09-13 10:31:56 PDT
(In reply to comment #1) > Created an attachment (id=163901) [details] > Patch lgtm !
Adrienne Walker
Comment 5 2012-09-13 10:43:04 PDT
Comment on attachment 163901 [details] Patch R=me.
WebKit Review Bot
Comment 6 2012-09-13 11:16:10 PDT
Comment on attachment 163901 [details] Patch Clearing flags on attachment: 163901 Committed r128483: <http://trac.webkit.org/changeset/128483>
WebKit Review Bot
Comment 7 2012-09-13 11:16:13 PDT
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 8 2012-09-13 11:51:20 PDT
You broke PlatformGestureCurve.flingCurveTouch on all platforms. Please fix ASAP. Failure log: PlatformGestureCurve.flingCurveTouch: ../../third_party/WebKit/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp:110: Failure Value of: animation->animate(1.5) Actual: true Expected: false ../../third_party/WebKit/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp:111: Failure The difference between target.cumulativeDelta().x() and 1193 is 1569, which exceeds 1, where target.cumulativeDelta().x() evaluates to 2762, 1193 evaluates to 1193, and 1 evaluates to 1.
Robert Kroeger
Comment 9 2012-09-13 12:33:07 PDT
Created attachment 163936 [details] Patch
Adrienne Walker
Comment 10 2012-09-13 12:36:52 PDT
Comment on attachment 163936 [details] Patch R=me. In the future, please do not upload multiple patches to the same bug in WebKit. Create a new bug instead.
Robert Kroeger
Comment 11 2012-09-13 12:58:07 PDT
Created attachment 163943 [details] Patch
WebKit Review Bot
Comment 12 2012-09-13 13:26:02 PDT
Comment on attachment 163943 [details] Patch Clearing flags on attachment: 163943 Committed r128501: <http://trac.webkit.org/changeset/128501>
WebKit Review Bot
Comment 13 2012-09-13 13:26:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.