Bug 96661

Summary: [BlackBerry] ResourceRequest string optimizations
Product: WebKit Reporter: George Staikos <staikos>
Component: WebKit BlackBerryAssignee: Yong Li <yong.li.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
the patch none

George Staikos
Reported 2012-09-13 09:35:26 PDT
Reduce string ops in ResourceRequest
Attachments
Patch (2.20 KB, patch)
2012-09-13 09:37 PDT, George Staikos 		no flags
DetailsFormatted DiffDiff
the patch (1.63 KB, patch)
2012-09-13 12:07 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
George Staikos
Comment 1 2012-09-13 09:37:02 PDT
Created attachment 163890 [details] Patch
Yong Li
Comment 2 2012-09-13 12:07:06 PDT
Created attachment 163929 [details] the patch
Yong Li
Comment 3 2012-09-13 12:21:50 PDT
forgot to put the PR in changelog. it is PR 207965.
Rob Buis
Comment 4 2012-09-13 12:45:40 PDT
Comment on attachment 163929 [details] the patch Looks good, more concise :)
WebKit Review Bot
Comment 5 2012-09-13 12:55:20 PDT
Comment on attachment 163929 [details] the patch Rejecting attachment 163929 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/Source/WebKit/chromium/third_party/leveldatabase/src --revision 67 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 37>At revision 67. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13855116
Yong Li
Comment 6 2012-09-13 13:04:23 PDT
manually landed @r128497
Yong Li
Comment 7 2012-09-13 13:04:37 PDT
Comment on attachment 163929 [details] the patch clear flags
Note You need to log in before you can comment on or make changes to this bug.