Bug 96656

Summary: check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dpranke, eric, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zoltan Horvath 2012-09-13 08:35:09 PDT
Stylebot sends (More than one command on the same line  [whitespace/newline] [4]) warning 
if WTF_MAKE_NONCOPYABLE(ClassName); and WTF_MAKE_FAST_ALLOCATED; macros are used in the same line.

Since it is the preferred style, the script should not warn about it. (e.g. https://bugs.webkit.org/show_bug.cgi?id=96512#c2)
Comment 1 Zoltan Horvath 2012-09-14 03:16:42 PDT
Created attachment 164085 [details]
Patch
Comment 2 Adam Barth 2012-09-14 09:58:34 PDT
Comment on attachment 164085 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-09-14 10:05:10 PDT
Comment on attachment 164085 [details]
Patch

Clearing flags on attachment: 164085

Committed r128624: <http://trac.webkit.org/changeset/128624>
Comment 4 WebKit Review Bot 2012-09-14 10:05:14 PDT
All reviewed patches have been landed.  Closing bug.