Bug 96651 – [BlackBerry] Page Popup for Month is non-functional.

• Component: Forms
• Status: RESOLVED FIXED

<input type=month> is completely non-functional.  It behaves like it is requesting a dialog, but no dialog appears.  Likely this is missing an implementation for the type and the fail over isn't handled well.

Created attachment 163876 [details]
Patch

[Mike Fenton]

Comment on attachment 163876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163876&action=review

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp:77
> +        source.append("window.popupcontrol.show(\"Month\", ");

This should be appendLiteral.

Created attachment 163878 [details]
Patch

[Rob Buis]

Comment on attachment 163878 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 163878 [details]
Patch

Rejecting attachment 163878 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Chris Hutten-Czapski found in /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13852049

Created attachment 163881 [details]
Patch

Created attachment 163882 [details]
Patch

[Rob Buis]

Comment on attachment 163882 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 163882 [details]
Patch

Clearing flags on attachment: 163882

Committed r128471: <http://trac.webkit.org/changeset/128471>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.