Bug 96625

Summary: Refactor paint overflow clipping
Product: WebKit Reporter: Sami Kyöstilä <skyostil>
Component: New BugsAssignee: Sami Kyöstilä <skyostil>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, simon.fraser, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96087    
Attachments:
Description Flags
Patch
none
Patch none

Sami Kyöstilä
Reported 2012-09-13 02:59:20 PDT
Refactor paint overflow clipping
Attachments
Patch (7.77 KB, patch)
2012-09-13 03:06 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Patch (7.77 KB, patch)
2012-09-13 03:15 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sami Kyöstilä
Comment 1 2012-09-13 03:06:06 PDT
Created attachment 163827 [details] Patch
Sami Kyöstilä
Comment 2 2012-09-13 03:15:36 PDT
Created attachment 163828 [details] Patch
Antonio Gomes
Comment 3 2012-09-13 06:41:21 PDT
Comment on attachment 163828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163828&action=review > Source/WebCore/rendering/RenderBox.cpp:1588 > + rect.setLocation(topLeft); is it ok to change the rect.location here unconditionally now? (previously it was within the else).
Sami Kyöstilä
Comment 4 2012-09-13 07:08:32 PDT
Comment on attachment 163828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163828&action=review >> Source/WebCore/rendering/RenderBox.cpp:1588 >> + rect.setLocation(topLeft); > > is it ok to change the rect.location here unconditionally now? (previously it was within the else). Both versions of the code should be equivalent. The old code constructs a temporary rectangle at (topLeft - scrollOffset, rect.size()) and assigns its intersection with the clip rect to rect. The new code does the same without the intermediate rectangle.
WebKit Review Bot
Comment 5 2012-09-13 10:21:59 PDT
Comment on attachment 163828 [details] Patch Clearing flags on attachment: 163828 Committed r128478: <http://trac.webkit.org/changeset/128478>
WebKit Review Bot
Comment 6 2012-09-13 10:22:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.