Bug 96609

Summary: [WK2][WTR] More efficient string handling in InjectedBundlePage
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, gyuyoung.kim, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://trac.webkit.org/wiki/EfficientStrings
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-09-13 00:02:22 PDT
InjectedBundlePage is using StringBuilder class but is not following the latest recommandations from http://trac.webkit.org/wiki/EfficientStrings for efficient string handling.
Attachments
Patch (55.04 KB, patch)
2012-09-13 00:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-13 00:06:25 PDT
Created attachment 163792 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-13 01:09:37 PDT
Comment on attachment 163792 [details] Patch Very nice, and dumpResourceURL makes the code a bit cleaner
WebKit Review Bot
Comment 3 2012-09-13 01:29:09 PDT
Comment on attachment 163792 [details] Patch Clearing flags on attachment: 163792 Committed r128421: <http://trac.webkit.org/changeset/128421>
WebKit Review Bot
Comment 4 2012-09-13 01:29:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.