Bug 96609 - [WK2][WTR] More efficient string handling in InjectedBundlePage
Summary: [WK2][WTR] More efficient string handling in InjectedBundlePage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://trac.webkit.org/wiki/Efficient...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 00:02 PDT by Chris Dumez
Modified: 2012-09-13 01:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (55.04 KB, patch)
2012-09-13 00:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-13 00:02:22 PDT 
InjectedBundlePage is using StringBuilder class but is not following the latest recommandations from http://trac.webkit.org/wiki/EfficientStrings for efficient string handling.
Comment 1 Chris Dumez 2012-09-13 00:06:25 PDT 
Created attachment 163792 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-09-13 01:09:37 PDT 
Comment on attachment 163792 [details]
Patch

Very nice, and dumpResourceURL makes the code a bit cleaner
Comment 3 WebKit Review Bot 2012-09-13 01:29:09 PDT 
Comment on attachment 163792 [details]
Patch

Clearing flags on attachment: 163792

Committed r128421: <http://trac.webkit.org/changeset/128421>
Comment 4 WebKit Review Bot 2012-09-13 01:29:12 PDT 
All reviewed patches have been landed.  Closing bug.