Summary: | [EFL][WK2] Make _ref() functions return the object | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2012-09-12 23:10:35 PDT
Created attachment 163787 [details]
Patch
Of course, I'll update the EFL coding guidelines when this lands. Comment on attachment 163787 [details]
Patch
Looks good refactoring.
Comment on attachment 163787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163787&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Make _ref() functions return the object Nit: missing [WK2] prefix. Created attachment 163797 [details]
Patch for landing
Could someone please cq+?
Comment on attachment 163797 [details] Patch for landing Clearing flags on attachment: 163797 Committed r128413: <http://trac.webkit.org/changeset/128413> All reviewed patches have been landed. Closing bug. |