Bug 96598

Summary: [EFL] Improve string manipulation in EflKeyboardUtilities.cpp
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2012-09-12 21:19:33 PDT
I think that we should remove String::format and use ASCIILiteral. Patch will be added.
Attachments
Patch (14.30 KB, patch)
2012-09-12 21:44 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-09-12 21:44:57 PDT
Created attachment 163770 [details] Patch
Benjamin Poulain
Comment 2 2012-09-13 13:43:14 PDT
Comment on attachment 163770 [details] Patch Looks good to me.
WebKit Review Bot
Comment 3 2012-09-13 15:58:23 PDT
Comment on attachment 163770 [details] Patch Clearing flags on attachment: 163770 Committed r128519: <http://trac.webkit.org/changeset/128519>
WebKit Review Bot
Comment 4 2012-09-13 15:58:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.