Bug 96595

Summary:

[Tests] We should have tests for preserving/resetting values of input type "time" after browser navigation

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none
Patch 4	none

yosin

Reported 2012-09-12 20:42:39 PDT

Browser navigation, e.g. reload, history.back, and history.forward, should preserve values of input type "time".

Attachments
Patch 1 (7.74 KB, patch) 2012-09-12 20:49 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 (7.93 KB, patch) 2012-09-12 23:03 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 3 (8.13 KB, patch) 2012-09-12 23:17 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 4 (8.95 KB, patch) 2012-09-13 02:07 PDT, yosin	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-09-12 20:49:05 PDT

Created attachment 163766 [details] Patch 1

yosin

Comment 2 2012-09-12 21:26:38 PDT

Comment on attachment 163766 [details] Patch 1 Could you review this patch? Thanks in advance.

yosin

Comment 3 2012-09-12 23:03:08 PDT

Created attachment 163783 [details] Patch 2

yosin

Comment 4 2012-09-12 23:05:13 PDT

Comment on attachment 163783 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Rename test file time-multiple-fields-preserve-value-after-reload.* to time-multiple-fields-not-preserve-value-after-reload.* * Change reload test does right thing. Previous version checked value before reloaded.

yosin

Comment 5 2012-09-12 23:17:24 PDT

Created attachment 163786 [details] Patch 3

yosin

Comment 6 2012-09-12 23:18:17 PDT

Comment on attachment 163786 [details] Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Rename test file time-multiple-fields-preserve-value-after-reload.* to time-multiple-fields-reset-value-after-reload.* * Change reload test does right thing. Previous version checked value before reloaded.

Kent Tamura

Comment 7 2012-09-12 23:40:57 PDT

Comment on attachment 163786 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=163786&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt:9 > +PASS "backward full";"01:01" is "01:01" > +PASS "backward partial";"" is "" > +PASS "forward full";"02:02" is "02:02" > +PASS "forward partial";"" is "" "backward/forward full/partial" is hard to understand unless reading the test code carefully. Please show more descriptive strings. e.g. Went back to a page. Checking a field which had a full value: PASS "01:01" is "01:01" Went back to a page. Checking a field which had a partial value: ..

yosin

Comment 8 2012-09-13 02:07:18 PDT

Created attachment 163818 [details] Patch 4

yosin

Comment 9 2012-09-13 02:08:59 PDT

Comment on attachment 163818 [details] Patch 4 Could you review this patch? Thank in advance. = Changes since the last review = * Change test output descriptive in time-multiple-fields-preserve-value-after-history-back.html

Kent Tamura

Comment 10 2012-09-13 02:30:25 PDT

Comment on attachment 163818 [details] Patch 4 ok

yosin

Comment 11 2012-09-13 02:37:13 PDT

Comment on attachment 163818 [details] Patch 4 Clearing flags on attachment: 163818 Committed r128434: <http://trac.webkit.org/changeset/128434>

yosin

Comment 12 2012-09-13 02:37:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.