Bug 96551

Summary: IndexedDB: The |source| property of IDBFactory.open() request should be null
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2012-09-12 13:32:07 PDT
IndexedDB: The |source| property of IDBFactory.open() request should be null
Attachments
Patch (8.33 KB, patch)
2012-09-12 13:35 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-09-12 13:35:10 PDT
Created attachment 163680 [details] Patch
Joshua Bell
Comment 2 2012-09-12 13:36:11 PDT
Identified via W3C test submission: http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbfactory_open.htm dgrogan@ - can you take a look?
David Grogan
Comment 3 2012-09-12 13:41:42 PDT
LGTM
Joshua Bell
Comment 4 2012-09-12 13:42:16 PDT
Another easy one - tony@ - r? cq?
WebKit Review Bot
Comment 5 2012-09-12 15:21:44 PDT
Comment on attachment 163680 [details] Patch Clearing flags on attachment: 163680 Committed r128370: <http://trac.webkit.org/changeset/128370>
WebKit Review Bot
Comment 6 2012-09-12 15:21:47 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 7 2012-09-12 18:57:14 PDT
It seems this broke IndexedDBLayoutTest.BasicTests in Chromium content_browsertests. I'll roll r128370 out.
David Grogan
Comment 9 2012-09-12 19:00:25 PDT
Doh, we forgot about basics-shared-workers-expected.txt
Kent Tamura
Comment 10 2012-09-12 19:03:21 PDT
(In reply to comment #9) > Doh, we forgot about basics-shared-workers-expected.txt The failure isn't a regression, is it? So, I won't roll it out.
David Grogan
Comment 11 2012-09-12 19:06:12 PDT
(In reply to comment #10) > (In reply to comment #9) > > Doh, we forgot about basics-shared-workers-expected.txt > > The failure isn't a regression, is it? So, I won't roll it out. Right, we just need to update the expected file. I'll do that now. Thanks!
Note You need to log in before you can comment on or make changes to this bug.