Summary: | IndexedDB: The |source| property of IDBFactory.open() request should be null | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, dgrogan, tkent, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joshua Bell
2012-09-12 13:32:07 PDT
Created attachment 163680 [details]
Patch
Identified via W3C test submission: http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbfactory_open.htm dgrogan@ - can you take a look? LGTM Another easy one - tony@ - r? cq? Comment on attachment 163680 [details] Patch Clearing flags on attachment: 163680 Committed r128370: <http://trac.webkit.org/changeset/128370> All reviewed patches have been landed. Closing bug. It seems this broke IndexedDBLayoutTest.BasicTests in Chromium content_browsertests. I'll roll r128370 out. Doh, we forgot about basics-shared-workers-expected.txt (In reply to comment #9) > Doh, we forgot about basics-shared-workers-expected.txt The failure isn't a regression, is it? So, I won't roll it out. (In reply to comment #10) > (In reply to comment #9) > > Doh, we forgot about basics-shared-workers-expected.txt > > The failure isn't a regression, is it? So, I won't roll it out. Right, we just need to update the expected file. I'll do that now. Thanks! |