Summary: | Respect WEBKITOUTPUTDIR when running EFL tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||
Component: | Tools / Tests | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, gyuyoung.kim, hausmann, ojan, rakuco, tmpsantos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2012-09-12 08:39:56 PDT
Created attachment 163641 [details]
Patch
Comment on attachment 163641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163641&action=review > Tools/Scripts/webkitpy/layout_tests/port/driver.py:280 > + environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR'] I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ... (In reply to comment #2) > I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ... You are right, python loves throwing exceptions instead of returning None :-) Created attachment 163686 [details]
Patch
Comment on attachment 163686 [details] Patch Clearing flags on attachment: 163686 Committed r128364: <http://trac.webkit.org/changeset/128364> All reviewed patches have been landed. Closing bug. |