Bug 96528

Summary: Respect WEBKITOUTPUTDIR when running EFL tests
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: Tools / TestsAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, gyuyoung.kim, hausmann, ojan, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kenneth Rohde Christiansen
Reported 2012-09-12 08:39:56 PDT
SSIA
Attachments
Patch (1.83 KB, patch)
2012-09-12 08:41 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2012-09-12 13:56 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-09-12 08:41:21 PDT
Created attachment 163641 [details] Patch
Dirk Pranke
Comment 2 2012-09-12 09:24:57 PDT
Comment on attachment 163641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163641&action=review > Tools/Scripts/webkitpy/layout_tests/port/driver.py:280 > + environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR'] I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ...
Kenneth Rohde Christiansen
Comment 3 2012-09-12 13:55:26 PDT
(In reply to comment #2) > I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ... You are right, python loves throwing exceptions instead of returning None :-)
Kenneth Rohde Christiansen
Comment 4 2012-09-12 13:56:05 PDT
Created attachment 163686 [details] Patch
WebKit Review Bot
Comment 5 2012-09-12 14:48:46 PDT
Comment on attachment 163686 [details] Patch Clearing flags on attachment: 163686 Committed r128364: <http://trac.webkit.org/changeset/128364>
WebKit Review Bot
Comment 6 2012-09-12 14:48:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.