Bug 96512

Summary:

Extend the coverage of the Custom Allocation Framework in WebCore

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, dino, eric.carlson, eric, feature-media-reviews, gustavo, japhet, macpherson, menard, mifenton, mrobinson, noam, pnormand, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	buildbot: commit-queue-
proposed patch	buildbot: commit-queue-
proposed patch	buildbot: commit-queue-
proposed patch	eric: review+

Zoltan Horvath

Reported 2012-09-12 07:32:26 PDT

Add WTF_MAKE_FAST_ALLOCATED macro to some class declarations in WebCore because these are instantiated by 'new'. This patch continues the work I started in bug #95737.

Attachments
proposed patch (73.85 KB, patch) 2012-09-12 07:38 PDT, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (72.61 KB, patch) 2012-09-13 04:20 PDT, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (65.30 KB, patch) 2012-09-13 06:18 PDT, Zoltan Horvath	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (64.88 KB, patch) 2012-09-13 07:08 PDT, Zoltan Horvath	eric: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2012-09-12 07:38:25 PDT

Created attachment 163625 [details] proposed patch The style bot won't like this patch because of the same line macro usage, please ignore. (More than one command on the same line.)

WebKit Review Bot

Comment 2 2012-09-12 07:40:20 PDT

Attachment 163625 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.cpp:292: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:305: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:357: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:417: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:449: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:483: More than one command on the same line [whitespace/newline] [4] Source/WebCore/editing/SpellChecker.h:73: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScriptExecutionContext.cpp:70: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorHistory.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:76: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLMetaCharsetParser.h:40: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/network/ResourceResponseBase.h:195: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleResolver.cpp:255: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ElementShadow.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/ElementShadow.h:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScopedEventQueue.h:44: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/StyledElement.cpp:84: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleBuilder.h:59: More than one command on the same line [whitespace/newline] [4] Source/WebCore/loader/ResourceLoadScheduler.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLElementStack.h:54: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLToken.h:60: More than one command on the same line [whitespace/newline] [4] Source/WebCore/page/MemoryInfo.cpp:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/DOMEditor.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/text/TextCodecICU.h:66: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/DOMImplementation.h:80: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InjectedScriptManager.h:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/ValidationMessage.h:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/Modules/websockets/WebSocketHandshake.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/MarkupTokenBase.h:50: More than one command on the same line [whitespace/newline] [4] Total errors found: 30 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2012-09-12 10:28:23 PDT

Comment on attachment 163625 [details] proposed patch Attachment 163625 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13822829

Zoltan Horvath

Comment 4 2012-09-13 04:20:56 PDT

Created attachment 163835 [details] proposed patch WinBuild still doesn't like PassOwnPtr and our macro. Go EWS go... :)

WebKit Review Bot

Comment 5 2012-09-13 04:23:46 PDT

Attachment 163835 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.cpp:292: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:305: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:357: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:417: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:449: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorCSSAgent.cpp:483: More than one command on the same line [whitespace/newline] [4] Source/WebCore/editing/SpellChecker.h:73: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScriptExecutionContext.cpp:70: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorHistory.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:76: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLMetaCharsetParser.h:40: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/network/ResourceResponseBase.h:194: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleResolver.cpp:255: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ElementShadow.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/ElementShadow.h:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScopedEventQueue.h:44: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/StyledElement.cpp:84: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/ValidationMessage.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleBuilder.h:59: More than one command on the same line [whitespace/newline] [4] Source/WebCore/loader/ResourceLoadScheduler.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLElementStack.h:54: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLToken.h:60: More than one command on the same line [whitespace/newline] [4] Source/WebCore/page/MemoryInfo.cpp:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/DOMEditor.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/text/TextCodecICU.h:66: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/DOMImplementation.h:80: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InjectedScriptManager.h:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/Modules/websockets/WebSocketHandshake.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/MarkupTokenBase.h:50: More than one command on the same line [whitespace/newline] [4] Total errors found: 30 in 114 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2012-09-13 05:31:56 PDT

Comment on attachment 163835 [details] proposed patch Attachment 163835 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13852004

Zoltan Horvath

Comment 7 2012-09-13 06:18:24 PDT

Created attachment 163854 [details] proposed patch Win-ews shot.

WebKit Review Bot

Comment 8 2012-09-13 06:21:37 PDT

Attachment 163854 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.cpp:292: More than one command on the same line [whitespace/newline] [4] Source/WebCore/editing/SpellChecker.h:73: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorHistory.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:76: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLMetaCharsetParser.h:40: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/network/ResourceResponseBase.h:194: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleResolver.cpp:255: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ElementShadow.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/ElementShadow.h:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScopedEventQueue.h:44: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/StyledElement.cpp:84: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/ValidationMessage.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleBuilder.h:59: More than one command on the same line [whitespace/newline] [4] Source/WebCore/loader/ResourceLoadScheduler.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLElementStack.h:54: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLToken.h:60: More than one command on the same line [whitespace/newline] [4] Source/WebCore/page/MemoryInfo.cpp:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/DOMEditor.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/text/TextCodecICU.h:66: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/DOMImplementation.h:80: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InjectedScriptManager.h:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/Modules/websockets/WebSocketHandshake.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/MarkupTokenBase.h:50: More than one command on the same line [whitespace/newline] [4] Total errors found: 24 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 9 2012-09-13 07:01:25 PDT

Comment on attachment 163854 [details] proposed patch Attachment 163854 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13835597

Zoltan Horvath

Comment 10 2012-09-13 07:08:07 PDT

Created attachment 163864 [details] proposed patch Win-ews shot.

WebKit Review Bot

Comment 11 2012-09-13 07:11:21 PDT

Attachment 163864 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/editing/SpellChecker.h:73: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InspectorHistory.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:76: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLMetaCharsetParser.h:40: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/network/ResourceResponseBase.h:194: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleResolver.cpp:255: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ElementShadow.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/dom/ElementShadow.h:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/ScopedEventQueue.h:44: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/StyledElement.cpp:84: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/ValidationMessage.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/css/StyleBuilder.h:59: More than one command on the same line [whitespace/newline] [4] Source/WebCore/loader/ResourceLoadScheduler.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLElementStack.h:54: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/XMLToken.h:60: More than one command on the same line [whitespace/newline] [4] Source/WebCore/page/MemoryInfo.cpp:46: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/DOMEditor.h:50: More than one command on the same line [whitespace/newline] [4] Source/WebCore/platform/text/TextCodecICU.h:66: More than one command on the same line [whitespace/newline] [4] Source/WebCore/dom/DOMImplementation.h:80: More than one command on the same line [whitespace/newline] [4] Source/WebCore/inspector/InjectedScriptManager.h:47: More than one command on the same line [whitespace/newline] [4] Source/WebCore/Modules/websockets/WebSocketHandshake.h:49: More than one command on the same line [whitespace/newline] [4] Source/WebCore/xml/parser/MarkupTokenBase.h:50: More than one command on the same line [whitespace/newline] [4] Total errors found: 23 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 12 2012-09-13 08:28:09 PDT

We should either fix the style, or fix the style-bot not to warn about this pattern if it's the preferred style. :(

Zoltan Horvath

Comment 13 2012-09-13 08:35:52 PDT

(In reply to comment #12) > We should either fix the style, or fix the style-bot not to warn about this pattern if it's the preferred style. :( I'm going to fix the style checker tomorrow, bug #96656.

Eric Seidel (no email)

Comment 14 2012-09-13 09:30:30 PDT

Comment on attachment 163864 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=163864&action=review LGTM. This system is so fragile. :( >> Source/WebCore/Modules/websockets/WebSocketHandshake.h:49 >> + WTF_MAKE_NONCOPYABLE(WebSocketHandshake); WTF_MAKE_FAST_ALLOCATED; > > More than one command on the same line [whitespace/newline] [4] I'm not sure why same line is better. But I also don't think it matters. :)

Zoltan Horvath

Comment 15 2012-09-13 09:46:50 PDT

(In reply to comment #14) > >> Source/WebCore/Modules/websockets/WebSocketHandshake.h:49 > >> + WTF_MAKE_NONCOPYABLE(WebSocketHandshake); WTF_MAKE_FAST_ALLOCATED; > > > > More than one command on the same line [whitespace/newline] [4] > > I'm not sure why same line is better. But I also don't think it matters. :) Historically we had the FastAllocBase class and Noncopyable was inherited from FastAllocBase and when we changed the system to the macro based solution we talked this pattern with Darin. So now I followed the most used patterns. :) Thanks for the review!

Zoltan Horvath

Comment 16 2012-09-14 04:23:19 PDT

Landed in http://trac.webkit.org/changeset/128572

Note You need to log in before you can comment on or make changes to this bug.