Bug 96498

Summary: REGRESSION(r128280): it broke compilation on windows debug bot (Requested by loislo on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, loislo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96374    
Attachments:
Description Flags
ROLLOUT of r128280 none

Description WebKit Review Bot 2012-09-12 04:55:30 PDT 
http://trac.webkit.org/changeset/128280 broke the build:
it broke compilation on windows debug bot (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-09-12 04:56:08 PDT 
Created attachment 163590 [details]
ROLLOUT of r128280

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ilya Tikhonovsky 2012-09-12 05:15:12 PDT 
Comment on attachment 163590 [details]
ROLLOUT of r128280

Clearing flags on attachment: 163590

Committed r128296: <http://trac.webkit.org/changeset/128296>
Comment 3 Ilya Tikhonovsky 2012-09-12 05:15:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ilya Tikhonovsky 2012-09-12 05:48:30 PDT 
6>------ Build started: Project: InjectedBundle, Configuration: Release Win32 ------
6>Performing Pre-Build Event...
6>/usr/bin/bash
6>Performing Pre-Link Event...
6>Linking...
6>   Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\InjectedBundle.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\InjectedBundle.exp
6>InjectedBundlePage.obj : error LNK2019: unresolved external symbol "public: static class WTF::String __cdecl WTF::String::number(__int64)" (?number@String@WTF@@SA?AV12@_J@Z) referenced in function "private: void __thiscall WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota(struct OpaqueWKSecurityOrigin const *,__int64)" (?didReachApplicationCacheOriginQuota@InjectedBundlePage@WTR@@AAEXPBUOpaqueWKSecurityOrigin@@_J@Z)
6>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\InjectedBundle.dll : fatal error LNK1120: 1 unresolved externals
6>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\InjectedBundle\BuildLog.htm"
6>InjectedBundle - 2 error(s), 0 warning(s)