Bug 96484

Summary:

Remove last call to numberToString() from WebCore code

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	haraken: review+, haraken: commit-queue-
Patch	none

Patrick R. Gansterer

Reported 2012-09-12 02:28:00 PDT

Remove last call to numberToString() from WebCore code

Attachments
Patch (5.61 KB, patch) 2012-09-12 02:36 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (4.82 KB, patch) 2012-09-12 02:37 PDT, Patrick R. Gansterer	haraken: review+ haraken: commit-queue-	Details Formatted Diff Diff
Patch (4.82 KB, patch) 2012-09-12 02:56 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2012-09-12 02:36:30 PDT

Patrick R. Gansterer

Comment 2 2012-09-12 02:37:44 PDT

Kentaro Hara

Comment 3 2012-09-12 02:44:47 PDT

Comment on attachment 163561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163561&action=review Looks OK. > Source/WebCore/ChangeLog:8 > + Repace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated Typo: Replace. Sorry for a nit-picking, but let's just fix it before landing.

Patrick R. Gansterer

Comment 4 2012-09-12 02:56:24 PDT

WebKit Review Bot

Comment 5 2012-09-12 06:50:40 PDT

WebKit Review Bot

Comment 6 2012-09-12 06:50:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.