Bug 96429

Summary: Add 'any' type to V8 bindings as a synonym for DOMObject
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Alec Flett 2012-09-11 14:56:28 PDT
Add 'any' type to V8 bindings as a synonym for DOMObject
Comment 1 Alec Flett 2012-09-11 15:09:50 PDT
Created attachment 163453 [details]
Patch
Comment 2 Alec Flett 2012-09-11 15:10:43 PDT
I have no idea what I'm doing.

Ok, I have some idea.

But I don't know how much of JSC I should worry about. 

haraken@ or abarth@ - can you offer any guidance?
Comment 3 Adam Barth 2012-09-11 15:24:21 PDT
Comment on attachment 163453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163453&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1369
> +    impl->setAnyAttribute(SerializedScriptValue::create(exec, value, 0, 0));

This seems to imply that "any" maps to SerializedScriptValue is JSC.  Is that what you intend?
Comment 4 Alec Flett 2012-09-11 16:46:59 PDT
Created attachment 163479 [details]
Patch
Comment 5 Kentaro Hara 2012-09-11 16:50:25 PDT
Comment on attachment 163479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163479&action=review

OK

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:251
> +        or $type eq "DOMString" or $type eq "DOMObject" or $type eq "any" or$type eq "Array" or $type eq "DOMTimeStamp") {

Nit: One space please after 'or'.
Comment 6 Alec Flett 2012-09-11 17:01:03 PDT
Created attachment 163483 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-11 17:34:46 PDT
Comment on attachment 163483 [details]
Patch for landing

Clearing flags on attachment: 163483

Committed r128248: <http://trac.webkit.org/changeset/128248>
Comment 8 WebKit Review Bot 2012-09-11 17:34:49 PDT
All reviewed patches have been landed.  Closing bug.