| Summary: | Garden-o-matic should ignore a wider variety of warnings in buildbot json | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||
| Component: | New Bugs | Assignee: | Adam Klein <adamk> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Klein
2012-09-11 11:20:37 PDT
Created attachment 163409 [details]
Patch
Comment on attachment 163409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 > + function isWarning(text) { return text.indexOf('warning') != -1; } > + return step.results[0] > 0 && !step.text.some(isWarning); I would have just used an anonymous function, but this is fine too. Comment on attachment 163409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 >> + return step.results[0] > 0 && !step.text.some(isWarning); > > I would have just used an anonymous function, but this is fine too. I found the anonymous function version hard to reason about; adding the name made this more readable to me. Comment on attachment 163409 [details] Patch Clearing flags on attachment: 163409 Committed r128213: <http://trac.webkit.org/changeset/128213> All reviewed patches have been landed. Closing bug. |