Bug 96411 – Garden-o-matic should ignore a wider variety of warnings in buildbot json

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Klein]

Garden-o-matic should ignore a wider variety of warnings in buildbot json

[Adam Klein]

Created attachment 163409 [details]
Patch

[Adam Barth]

Comment on attachment 163409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60
> +    function isWarning(text) { return text.indexOf('warning') != -1; }
> +    return step.results[0] > 0 && !step.text.some(isWarning);

I would have just used an anonymous function, but this is fine too.

[Adam Klein]

Comment on attachment 163409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60
>> +    return step.results[0] > 0 && !step.text.some(isWarning);
> 
> I would have just used an anonymous function, but this is fine too.

I found the anonymous function version hard to reason about; adding the name made this more readable to me.

[WebKit Review Bot]

Comment on attachment 163409 [details]
Patch

Clearing flags on attachment: 163409

Committed r128213: <http://trac.webkit.org/changeset/128213>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.