Bug 96391

Summary:

[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of webkit in order to include libraries of slog2

Product:

WebKit

Reporter:

Parth Patel <parpatel>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Parth Patel 2012-09-11 08:12:56 PDT

Modification in CMakelist in JavaScriptCore of webkit to include libraries of Slog2 in build files of webkit.

Comment 1 Parth Patel 2012-09-11 08:47:28 PDT

Created attachment 163376 [details]
Patch

Comment 2 Yong Li 2012-09-11 08:50:26 PDT

Comment on attachment 163376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163376&action=review

LGTM

> Source/JavaScriptCore/ChangeLog:9
> +        Changes in Cmake files of JavaScriptCore of webkit to include slog2 libs in build 

Cmake => CMake?

Comment 3 Parth Patel 2012-09-11 08:51:18 PDT

Comment on attachment 163376 [details]
Patch

request for commit-queue? after r+

Comment 4 WebKit Review Bot 2012-09-14 06:08:12 PDT

Comment on attachment 163376 [details]
Patch

Clearing flags on attachment: 163376

Committed r128599: <http://trac.webkit.org/changeset/128599>

Comment 5 WebKit Review Bot 2012-09-14 06:08:15 PDT

All reviewed patches have been landed.  Closing bug.