Summary: | [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Component: | WebKit2 | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-09-11 07:34:26 PDT
Created attachment 163371 [details]
patch
Comment on attachment 163371 [details] patch Rejecting attachment 163371 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: atching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl Hunk #1 succeeded at 80 (offset 1 line). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp Hunk #1 succeeded at 567 (offset 11 lines). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Hunk #1 succeeded at 203 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13828118 Comment on attachment 163371 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274 > +size_t WKBundleWorkerThreadCount(WKBundleRef) I think the API guidelines says to add Get in the name. (In reply to comment #3) > (From update of attachment 163371 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274 > > +size_t WKBundleWorkerThreadCount(WKBundleRef) > > I think the API guidelines says to add Get in the name. Seems not in this file: WKBundleNumberOfPages(), WKBundlePageNumberForElementById(), WKBundlePageSizeAndMarginsInPixels() and so on.. Created attachment 163534 [details]
to be landed
Comment on attachment 163534 [details] to be landed View in context: https://bugs.webkit.org/attachment.cgi?id=163534&action=review > Source/WebKit2/ChangeLog:8 > + Added WKBundleWorkerThreadCount() function to Injected Bundle private API. Didnt we agree to rename it WKBundleGetWorkerThreadCount? Created attachment 163547 [details]
renamed
Comment on attachment 163547 [details] renamed Clearing flags on attachment: 163547 Committed r128278: <http://trac.webkit.org/changeset/128278> All reviewed patches have been landed. Closing bug. |