Bug 96388

Summary: [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kenneth: review+, webkit.review.bot: commit-queue-
to be landed
none
renamed none

Mikhail Pozdnyakov
Reported 2012-09-11 07:34:26 PDT
WebKitTestRunner needs TestRunner.workerThreadCount in order to unskip fast/workers/dedicated-worker-lifecycle.html fast/workers/shared-worker-frame-lifecycle.html fast/workers/shared-worker-lifecycle.html fast/workers/worker-lifecycle.html fast/workers/worker-close-more.html
Attachments
patch (8.19 KB, patch)
2012-09-11 08:26 PDT, Mikhail Pozdnyakov 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
to be landed (8.07 KB, patch)
2012-09-12 00:26 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
renamed (8.08 KB, patch)
2012-09-12 01:48 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-09-11 08:26:28 PDT
Created attachment 163371 [details] patch
WebKit Review Bot
Comment 2 2012-09-11 08:30:21 PDT
Comment on attachment 163371 [details] patch Rejecting attachment 163371 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: atching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl Hunk #1 succeeded at 80 (offset 1 line). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp Hunk #1 succeeded at 567 (offset 11 lines). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Hunk #1 succeeded at 203 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13828118
Kenneth Rohde Christiansen
Comment 3 2012-09-11 08:31:39 PDT
Comment on attachment 163371 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274 > +size_t WKBundleWorkerThreadCount(WKBundleRef) I think the API guidelines says to add Get in the name.
Mikhail Pozdnyakov
Comment 4 2012-09-12 00:24:44 PDT
(In reply to comment #3) > (From update of attachment 163371 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274 > > +size_t WKBundleWorkerThreadCount(WKBundleRef) > > I think the API guidelines says to add Get in the name. Seems not in this file: WKBundleNumberOfPages(), WKBundlePageNumberForElementById(), WKBundlePageSizeAndMarginsInPixels() and so on..
Mikhail Pozdnyakov
Comment 5 2012-09-12 00:26:22 PDT
Created attachment 163534 [details] to be landed
Kenneth Rohde Christiansen
Comment 6 2012-09-12 00:39:37 PDT
Comment on attachment 163534 [details] to be landed View in context: https://bugs.webkit.org/attachment.cgi?id=163534&action=review > Source/WebKit2/ChangeLog:8 > + Added WKBundleWorkerThreadCount() function to Injected Bundle private API. Didnt we agree to rename it WKBundleGetWorkerThreadCount?
Mikhail Pozdnyakov
Comment 7 2012-09-12 01:48:56 PDT
Created attachment 163547 [details] renamed
WebKit Review Bot
Comment 8 2012-09-12 02:09:44 PDT
Comment on attachment 163547 [details] renamed Clearing flags on attachment: 163547 Committed r128278: <http://trac.webkit.org/changeset/128278>
WebKit Review Bot
Comment 9 2012-09-12 02:09:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.