Bug 96379

Summary: [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96374    
Attachments:
Description Flags
Patch
kenneth: review+, kenneth: commit-queue-
Patch for landing none

Description Chris Dumez 2012-09-11 05:34:17 PDT 
TestRunner needs to implement setApplicationCacheOriginQuota.

This is needed by the following test cases:
  LayoutTests/http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
  LayoutTests/http/tests/appcache/origin-quota-continued-download.html
  LayoutTests/http/tests/appcache/origin-quota.html
Comment 1 Chris Dumez 2012-09-11 05:46:25 PDT 
Created attachment 163343 [details]
Patch
Comment 2 Chris Dumez 2012-09-11 05:46:53 PDT 
Unforunately, tests cannot be unskipped yet due to Bug 96374.
Comment 3 Kenneth Rohde Christiansen 2012-09-11 05:48:30 PDT 
Comment on attachment 163343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163343&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:100
> +WK_EXPORT void WKBundleSetApplicationCacheOriginQuota(WKBundleRef bundle, WKStringRef origin, uint64_t quota);

so quote is in MB? I think the variable name should make that clearer
Comment 4 Chris Dumez 2012-09-11 06:42:51 PDT 
Created attachment 163352 [details]
Patch for landing

Take Kenneth's feedback into consideration.
Comment 5 WebKit Review Bot 2012-09-11 08:23:14 PDT 
Comment on attachment 163352 [details]
Patch for landing

Clearing flags on attachment: 163352

Committed r128190: <http://trac.webkit.org/changeset/128190>
Comment 6 WebKit Review Bot 2012-09-11 08:23:19 PDT 
All reviewed patches have been landed.  Closing bug.