Bug 96363

Summary: Create Localizer factory method for LocaleICU
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96351    
Attachments:
Description Flags
Patch none

Description Keishi Hattori 2012-09-11 01:27:24 PDT
Create Localizer factory method for LocaleICU
Comment 1 Keishi Hattori 2012-09-11 01:53:53 PDT
Created attachment 163303 [details]
Patch
Comment 2 Kent Tamura 2012-09-11 02:03:39 PDT
Comment on attachment 163303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163303&action=review

> Source/WebCore/platform/text/LocaleICU.cpp:47
> +    return LocaleICU::create(locale.string().utf8().data());

What happens if a broken locale name is specified?
e.g. Null AtomicString, empty string, "12345"
Comment 3 WebKit Review Bot 2012-09-11 19:24:35 PDT
Comment on attachment 163303 [details]
Patch

Clearing flags on attachment: 163303

Committed r128257: <http://trac.webkit.org/changeset/128257>
Comment 4 WebKit Review Bot 2012-09-11 19:24:38 PDT
All reviewed patches have been landed.  Closing bug.