Bug 96362

Summary:

[BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser

Product:

WebKit

Reporter:

Sean Wang <xuewen.ok>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

charles.wei, chutten, joenotcharles, jonathan.dong.webkit, mifenton, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	rwlbuis: review+
rebase patch	none
patch	none
Fix a mistake in the last patch	none

Sean Wang

Reported 2012-09-11 00:46:22 PDT

Even user has stored the site's credentials, after restarting browser and accessing the site, the browser will still ask for credentials. By now, the blackberry porting doesn't load credentials from persistent storage.

Attachments
patch (11.39 KB, patch) 2012-09-11 01:10 PDT, Sean Wang	rwlbuis: review+	Details Formatted Diff Diff
rebase patch (11.53 KB, patch) 2012-09-19 00:04 PDT, Sean Wang	no flags	Details Formatted Diff Diff
patch (11.52 KB, patch) 2012-09-19 02:53 PDT, Sean Wang	no flags	Details Formatted Diff Diff
Fix a mistake in the last patch (2.67 KB, patch) 2012-09-20 22:46 PDT, Sean Wang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sean Wang

Comment 1 2012-09-11 01:10:13 PDT

Created attachment 163297 [details] patch This patch is not good enough in performance, but it resolved this issue. Know issues for this patch: It will search for credentials for every request before sending it including the URLs which don't require credentials. The performance issue should/would be fixed in the future patches.

Joe Mason

Comment 2 2012-09-11 10:28:08 PDT

This has been internally reviewed, right? (I think by me, but I forget if I gave it the final r+. I definitely looked at it.)

Sean Wang

Comment 3 2012-09-11 12:50:39 PDT

(In reply to comment #2) > This has been internally reviewed, right? (I think by me, but I forget if I gave it the final r+. I definitely looked at it.) Yes, you have given r+ internally to the PR200694.

Rob Buis

Comment 4 2012-09-17 07:36:53 PDT

Comment on attachment 163297 [details] patch LGTM.

Sean Wang

Comment 5 2012-09-19 00:04:14 PDT

Created attachment 164675 [details] rebase patch The code base has changed in Source/WebCore/platform/network/blackberry/NetworkManager.cpp, I re-applied the last r+ed patch and made this patch. At the same time, I added the macro BLACKBERRY_CREDENTIAL_PERSIST to include Settings.h, since it is only used by this change. +#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST) +#include "Settings.h" +#endif

WebKit Review Bot

Comment 6 2012-09-19 00:07:07 PDT

Attachment 164675 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1020: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h:59: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sean Wang

Comment 7 2012-09-19 02:53:02 PDT

Created attachment 164702 [details] patch Correct the style error of the rebased patch.

Rob Buis

Comment 8 2012-09-19 07:28:07 PDT

Comment on attachment 164702 [details] patch Looks good.

Charles Wei

Comment 9 2012-09-19 19:08:40 PDT

Comment on attachment 164702 [details] patch commit.

WebKit Review Bot

Comment 10 2012-09-19 19:34:20 PDT

Comment on attachment 164702 [details] patch Clearing flags on attachment: 164702 Committed r129087: <http://trac.webkit.org/changeset/129087>

WebKit Review Bot

Comment 11 2012-09-19 19:34:23 PDT

All reviewed patches have been landed. Closing bug.

Sean Wang

Comment 12 2012-09-20 22:46:29 PDT

Created attachment 165053 [details] Fix a mistake in the last patch Since the trunk has been changed during reviewing the last patch, one line of the last patch can cause build failure. This patch is to sync with blackberry trunk.

Rob Buis

Comment 13 2012-09-24 07:23:48 PDT

Comment on attachment 165053 [details] Fix a mistake in the last patch Looks good.

Rob Buis

Comment 14 2012-09-24 10:57:35 PDT

Last patch still needs to go in.

WebKit Review Bot

Comment 15 2012-09-24 11:33:57 PDT

Comment on attachment 165053 [details] Fix a mistake in the last patch Clearing flags on attachment: 165053 Committed r129392: <http://trac.webkit.org/changeset/129392>

WebKit Review Bot

Comment 16 2012-09-24 11:34:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.