Bug 96358

Summary: [Qt] Build on Windows requires bison/flex in PATH
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dino, kevin.funk, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96359    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Simon Hausmann 2012-09-11 00:21:02 PDT 
[Qt] Build on Windows requires bison/flex in PATH
Comment 1 Simon Hausmann 2012-09-11 00:26:45 PDT 
Created attachment 163292 [details]
Patch
Comment 2 Simon Hausmann 2012-09-11 01:57:53 PDT 
Created attachment 163305 [details]
Patch

Updated patch to accomodate ANGLE windows build
Comment 3 Simon Hausmann 2012-09-11 23:54:17 PDT 
Created attachment 163526 [details]
Patch

Updated patch that modifies the tools-in-PATH check on Windows to look for win_flex instead of flex
Comment 4 WebKit Review Bot 2012-09-12 07:34:40 PDT 
Comment on attachment 163305 [details]
Patch

Clearing flags on attachment: 163305

Committed r128308: <http://trac.webkit.org/changeset/128308>
Comment 5 WebKit Review Bot 2012-09-12 07:34:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kevin Funk 2012-09-12 09:02:12 PDT 
Note: This patch breaks the generator commands in case GNUTOOLS references an invalid directory, please reconsider.

'$${GNUTOOLS} && $$val_escape($${generator}.commands)' then evaluates to 'SOME_DIR && ...' which breaks compilation.
Comment 7 Simon Hausmann 2012-09-12 09:34:11 PDT 
(In reply to comment #6)
> Note: This patch breaks the generator commands in case GNUTOOLS references an invalid directory, please reconsider.
> 
> '$${GNUTOOLS} && $$val_escape($${generator}.commands)' then evaluates to 'SOME_DIR && ...' which breaks compilation.

Ooops! Well spotted. I'll fix it right away.
Comment 8 Simon Hausmann 2012-09-12 09:43:09 PDT 
Prospectively fixed in http://trac.webkit.org/changeset/128328