| Summary: | [CMake] Remove duplicated file in CMakeLists.txt | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 91575 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 163259 [details]
Patch
Comment on attachment 163259 [details]
Patch
Shouldn't it be the other way around? Remove the files from the main section, and keep the guarded build one?
What if you want a build without ENABLE_VIBRATION?
Comment on attachment 163259 [details]
Patch
Ok, the file are #ifdef'ed and you prefer to support only that way.
Comment on attachment 163259 [details] Patch Clearing flags on attachment: 163259 Committed r128143: <http://trac.webkit.org/changeset/128143> All reviewed patches have been landed. Closing bug. |
Below files are already added to main file list in WebCore/CMakeLists.txt. So, this should be removed. IF (ENABLE_REQUEST_ANIMATION_FRAME) LIST(APPEND WebCore_IDL_FILES dom/RequestAnimationFrameCallback.idl ) LIST(APPEND WebCore_SOURCES dom/ScriptedAnimationController.cpp ) ENDIF () IF (ENABLE_VIBRATION) LIST(APPEND WebCore_INCLUDE_DIRECTORIES ${WEBCORE_DIR}/Modules/vibration ) LIST(APPEND WebCore_IDL_FILES Modules/vibration/NavigatorVibration.idl ) LIST(APPEND WebCore_SOURCES Modules/vibration/NavigatorVibration.cpp Modules/vibration/Vibration.cpp ) ENDIF ()