Bug 96319

Summary: Rename box-sizing applying methods to be more clear about just applying box-sizing.
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ojan Vafai
Reported 2012-09-10 14:31:40 PDT
Rename box-sizing applying methods to be more clear about just applying box-sizing.
Attachments
Patch (41.67 KB, patch)
2012-09-10 14:33 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.91 KB, patch)
2012-09-10 14:50 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-09-10 14:33:23 PDT
Created attachment 163210 [details] Patch
Tony Chang
Comment 2 2012-09-10 14:39:31 PDT
Comment on attachment 163210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163210&action=review > Source/WebCore/rendering/AutoTableLayout.cpp:96 > + LayoutUnit logicalWidth = cell->adjustBorderLogicalWidthForBoxSizing(cellLogicalWidth.value()); Nit: I would call it adjustBorderBoxLogicalWidthForBoxSizing to make it clear that we're not talking about the border width. > Source/WebCore/rendering/RenderBlock.cpp:5555 > + m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = adjustContentLogicalWidthForBoxSizing(styleToUse->logicalWidth().value()); Nit: adjustContentBoxLogicalWidthForBoxSizing.
Ojan Vafai
Comment 3 2012-09-10 14:50:49 PDT
Created attachment 163214 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-09-10 16:55:15 PDT
Comment on attachment 163214 [details] Patch for landing Clearing flags on attachment: 163214 Committed r128130: <http://trac.webkit.org/changeset/128130>
WebKit Review Bot
Comment 5 2012-09-10 16:55:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.