Bug 96312

Summary:

[V8] currentDocument doesn't need to handle the case where there is no v8::Context

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2012-09-10 13:41:33 PDT

[V8] currentDocument doesn't need to handle the case where there is no v8::Context

Comment 1 Adam Barth 2012-09-10 13:42:17 PDT

Created attachment 163197 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-09-10 13:46:55 PDT

Comment on attachment 163197 [details]
Patch

k

Comment 3 Kentaro Hara 2012-09-10 13:48:25 PDT

In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:)

Comment 4 Adam Barth 2012-09-10 13:53:41 PDT

> In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:)

Sure.  If you see places where you think that would be useful, please mention them and I will add the ASSERTs.

Comment 5 Adam Barth 2012-09-10 16:21:19 PDT

Comment on attachment 163197 [details]
Patch

Clearing flags on attachment: 163197

Committed r128124: <http://trac.webkit.org/changeset/128124>

Comment 6 Adam Barth 2012-09-10 16:21:21 PDT

All reviewed patches have been landed.  Closing bug.