Bug 96311

Summary: Remove m_classInfo from JSCell
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2012-09-10 13:38:27 PDT
Now that no one is using the ClassInfo in JSCell, we can remove it for the greater good.
Attachments
Patch (15.49 KB, patch)
2012-09-10 17:50 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (15.50 KB, patch)
2012-09-10 18:09 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-09-10 17:50:16 PDT
Created attachment 163257 [details] Patch
Mark Hahnenberg
Comment 2 2012-09-10 18:09:27 PDT
Created attachment 163258 [details] Patch
Oliver Hunt
Comment 3 2012-09-10 18:14:21 PDT
Comment on attachment 163258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163258&action=review r=me assuming 32_64 changes are in fact legitimate > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:91 > + const InlineStorageCapacity = 7 Does 32bit gain a full JSValue in a cell? You've removed one pointer but a value is 64bits. > Source/JavaScriptCore/runtime/PropertyOffset.h:39 > -#define INLINE_STORAGE_CAPACITY 6 > +#define INLINE_STORAGE_CAPACITY 7 > #else > -#define INLINE_STORAGE_CAPACITY 5 > +#define INLINE_STORAGE_CAPACITY 6 See my earlier comment
Mark Hahnenberg
Comment 4 2012-09-10 18:40:32 PDT
(In reply to comment #3) > (From update of attachment 163258 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163258&action=review > > r=me assuming 32_64 changes are in fact legitimate > > > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:91 > > + const InlineStorageCapacity = 7 > > Does 32bit gain a full JSValue in a cell? You've removed one pointer but a value is 64bits. > It should be okay because I removed a void* that was added on 32_64 to pad out JSObjects after I removed inheritorID a while back. So technically there were two pointer-sized removals on 32_64 in this patch.
Mark Hahnenberg
Comment 5 2012-09-10 18:41:10 PDT
> It should be okay because I removed a void* that was added on 32_64 to pad out JSObjects after I removed inheritorID a while back. So technically there were two pointer-sized removals on 32_64 in this patch. (See changes to JSObject.h in this patch)
WebKit Review Bot
Comment 6 2012-09-10 22:05:30 PDT
Comment on attachment 163258 [details] Patch Clearing flags on attachment: 163258 Committed r128146: <http://trac.webkit.org/changeset/128146>
WebKit Review Bot
Comment 7 2012-09-10 22:05:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.