Bug 96307

Summary: Silence a warning when running update-webkit-localizable-strings
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sullivan: review+

Anders Carlsson
Reported 2012-09-10 13:20:18 PDT
Silence a warning when running update-webkit-localizable-strings
Attachments
Patch (2.08 KB, patch)
2012-09-10 13:21 PDT, Anders Carlsson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-09-10 13:21:50 PDT
Created attachment 163191 [details] Patch
John Sullivan
Comment 2 2012-09-10 13:23:52 PDT
Comment on attachment 163191 [details] Patch The other way to do this would be to make the two instances have identical localizer comments, as long as we are certain that there’s no chance that the two strings would be localized differently (taking context into account) in any language.
John Sullivan
Comment 3 2012-09-10 13:25:27 PDT
Comment on attachment 163191 [details] Patch Oops, you also need to update Localizable.strings in this patch (you wouldn’t need to if you made the localizer comments the same).
John Sullivan
Comment 4 2012-09-10 13:28:25 PDT
Comment on attachment 163191 [details] Patch r+ assuming you also check in the updated Localizable.strings
Anders Carlsson
Comment 5 2012-09-10 13:30:53 PDT
Committed r128098: <http://trac.webkit.org/changeset/128098>
Note You need to log in before you can comment on or make changes to this bug.