| Summary: | Rename computeLogicalHeight to updateLogicalHeight | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric, hyatt, mifenton, ojan, tkent, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tony Chang
2012-09-10 13:04:25 PDT
Created attachment 163184 [details]
Patch
Comment on attachment 163184 [details]
Patch
See 96288 for the computeLogicalWidth rename.
Comment on attachment 163184 [details]
Patch
I bet I'll have to rebase after the computeLogicalWidth patch lands.
Created attachment 163222 [details]
Patch for landing
Comment on attachment 163222 [details] Patch for landing Rejecting attachment 163222 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 45>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13810418 Created attachment 163389 [details]
Patch for landing
Comment on attachment 163389 [details] Patch for landing Clearing flags on attachment: 163389 Committed r128201: <http://trac.webkit.org/changeset/128201> All reviewed patches have been landed. Closing bug. |