Bug 96305

Summary: Rename computeLogicalHeight to updateLogicalHeight
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, mifenton, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tony Chang
Reported 2012-09-10 13:04:25 PDT
Rename computeLogicalHeight to updateLogicalHeight
Attachments
Patch (32.72 KB, patch)
2012-09-10 13:05 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.79 KB, patch)
2012-09-10 15:12 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.78 KB, patch)
2012-09-11 09:56 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-09-10 13:05:19 PDT
Created attachment 163184 [details] Patch
Tony Chang
Comment 2 2012-09-10 13:06:04 PDT
Comment on attachment 163184 [details] Patch See 96288 for the computeLogicalWidth rename.
Tony Chang
Comment 3 2012-09-10 13:07:28 PDT
Comment on attachment 163184 [details] Patch I bet I'll have to rebase after the computeLogicalWidth patch lands.
Tony Chang
Comment 4 2012-09-10 15:12:05 PDT
Created attachment 163222 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-09-10 17:13:50 PDT
Comment on attachment 163222 [details] Patch for landing Rejecting attachment 163222 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 45>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13810418
Tony Chang
Comment 6 2012-09-11 09:56:15 PDT
Created attachment 163389 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-09-11 10:21:40 PDT
Comment on attachment 163389 [details] Patch for landing Clearing flags on attachment: 163389 Committed r128201: <http://trac.webkit.org/changeset/128201>
WebKit Review Bot
Comment 8 2012-09-11 10:21:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.