| Summary: | [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raul Hudea <rhudea> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, cmarcelo, donggwan.kim, macpherson, menard, mihnea, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 66643 | ||||||||
| Attachments: |
|
||||||||
|
Description
Raul Hudea
2012-09-10 12:24:02 PDT
Created attachment 164688 [details]
Expose webkitRegionOverset only if CSS_REGIONS is enabled
Created attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)
Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/css/StyleRule.cpp:87 > + ASSERT_NOT_REACHED(); Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable? (In reply to comment #3) > (From update of attachment 164713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > > > Source/WebCore/css/StyleRule.cpp:87 > > + ASSERT_NOT_REACHED(); > > Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable? in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) Clearing flags on attachment: 164713 Committed r129009: <http://trac.webkit.org/changeset/129009> All reviewed patches have been landed. Closing bug. Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/dom/Element.idl:146 > - readonly attribute DOMString webkitRegionOverset; > + readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset; Thanks! |