Bug 96300

Summary:

[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined

Product:

WebKit

Reporter:

Raul Hudea <rhudea>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, donggwan.kim, macpherson, menard, mihnea, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

66643

Attachments:

Description	Flags
Expose webkitRegionOverset only if CSS_REGIONS is enabled	none
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)	none

Raul Hudea

Reported 2012-09-10 12:24:02 PDT

At least one in Element.idl, regionOverset is visible.

Attachments
Expose webkitRegionOverset only if CSS_REGIONS is enabled (3.25 KB, patch) 2012-09-19 01:19 PDT, Raul Hudea	no flags	Details Formatted Diff Diff
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) (3.36 KB, patch) 2012-09-19 04:44 PDT, Raul Hudea	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Raul Hudea

Comment 1 2012-09-19 01:19:45 PDT

Created attachment 164688 [details] Expose webkitRegionOverset only if CSS_REGIONS is enabled

Raul Hudea

Comment 2 2012-09-19 04:44:02 PDT

Created attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

Yury Semikhatsky

Comment 3 2012-09-19 08:02:56 PDT

Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/css/StyleRule.cpp:87 > + ASSERT_NOT_REACHED(); Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?

Raul Hudea

Comment 4 2012-09-19 08:08:42 PDT

(In reply to comment #3) > (From update of attachment 164713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > > > Source/WebCore/css/StyleRule.cpp:87 > > + ASSERT_NOT_REACHED(); > > Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable? in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h

WebKit Review Bot

Comment 5 2012-09-19 08:30:21 PDT

Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) Clearing flags on attachment: 164713 Committed r129009: <http://trac.webkit.org/changeset/129009>

WebKit Review Bot

Comment 6 2012-09-19 08:30:24 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 7 2012-09-19 11:50:50 PDT

Comment on attachment 164713 [details] Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review > Source/WebCore/dom/Element.idl:146 > - readonly attribute DOMString webkitRegionOverset; > + readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset; Thanks!

Note You need to log in before you can comment on or make changes to this bug.