Bug 96273

Summary: [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit Misc.Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, paroga, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96254    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2012-09-10 07:39:50 PDT
CodeGeneratorTestRunner.pm needs FEATURE_DEFINES with space separator to know feature macros such as TOUCH_EVENTS.
Attachments
Patch (9.80 KB, patch)
2012-09-10 15:37 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-09-10 15:37:15 PDT
Created attachment 163232 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-09-11 05:50:18 PDT
Comment on attachment 163232 [details] Patch Makes sense, thank you.
Gyuyoung Kim
Comment 3 2012-09-11 21:16:50 PDT
Comment on attachment 163232 [details] Patch Looks make sense too.
WebKit Review Bot
Comment 4 2012-09-11 21:24:36 PDT
Comment on attachment 163232 [details] Patch Clearing flags on attachment: 163232 Committed r128261: <http://trac.webkit.org/changeset/128261>
WebKit Review Bot
Comment 5 2012-09-11 21:24:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.