Summary: | [EFL] Create a toggle button for closed captions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2012-09-10 04:43:29 PDT
Created attachment 163093 [details]
Patch
Comment on attachment 163093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163093&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:1303 > + Node* mediaNode = object->node() ? object->node()->shadowHost() : 0; > + if (!mediaNode) > + mediaNode = object->node(); > + if (!mediaNode || (!mediaNode->hasTagName(videoTag))) > + return false; So this is how it is done for other ports? Comment on attachment 163093 [details] Patch Clearing flags on attachment: 163093 Committed r128049: <http://trac.webkit.org/changeset/128049> All reviewed patches have been landed. Closing bug. |