Bug 96255

Summary:

Move InputTypeNames to a separate file

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, gyuyoung.kim, mifenton, rakuco, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Keishi Hattori 2012-09-10 03:36:35 PDT

We want to move InputTypeNames to a separate file so we can use it without including InputType.h

Comment 1 Keishi Hattori 2012-09-10 03:56:04 PDT

Created attachment 163082 [details]
Patch

Comment 2 Kent Tamura 2012-09-10 07:06:08 PDT

Comment on attachment 163082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163082&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25527
> +				C348612415FDE21E007A1CC9 /* InputTypeNames.h in Headers */,

nit: please insert this entry in alphabetical order.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28621
> +				C348612315FDE21E007A1CC9 /* InputTypeNames.cpp in Sources */,

ditto.

> Source/WebCore/html/InputTypeNames.cpp:9
> + * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
> + *           (C) 1999 Antti Koivisto (koivisto@kde.org)
> + *           (C) 2001 Dirk Mueller (mueller@kde.org)
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
> + *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
> + * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code was written by me in 2010, an Apple engineer updated some lines in this year, and you add some lines.

* Copyright (C) 2012 Apple Inc. All rights reserved.
* Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.

> Source/WebCore/html/InputTypeNames.h:9
> + * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
> + *           (C) 1999 Antti Koivisto (koivisto@kde.org)
> + *           (C) 2001 Dirk Mueller (mueller@kde.org)
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
> + *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
> + * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code of InputType.h was written by me in 2010, and you add some.  So,

Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.

Comment 3 Keishi Hattori 2012-09-10 19:08:52 PDT

Created attachment 163264 [details]
Patch

Comment 4 WebKit Review Bot 2012-09-10 22:43:46 PDT

Comment on attachment 163264 [details]
Patch

Clearing flags on attachment: 163264

Committed r128149: <http://trac.webkit.org/changeset/128149>

Comment 5 WebKit Review Bot 2012-09-10 22:43:50 PDT

All reviewed patches have been landed.  Closing bug.