|Summary:||AX: Update Windows port accessible role mappings to fix some tests|
|Product:||WebKit||Reporter:||Dominic Mazzoni <dmazzoni>|
|Component:||Accessibility||Assignee:||Dominic Mazzoni <dmazzoni>|
|Version:||528+ (Nightly build)|
Description Dominic Mazzoni 2012-09-09 14:58:41 PDT
Tests currently failing due to https://bugs.webkit.org/show_bug.cgi?id=94870: accessibility/adjacent-continuations-cause-assertion-failure.html accessibility/deleting-iframe-destroys-axcache.html accessibility/div-within-anchors-causes-crash.html
Comment 1 Dominic Mazzoni 2012-09-09 15:00:58 PDT
I'm uploading a patch that should fix the tests. While I was at it, I tried to map a few more accessible roles on Windows - the ones that I'm reasonably confident about based on the Chromium source code. Roger, could you patch this in and see if it fixes these three tests and doesn't break anything else on Windows?
Comment 3 Build Bot 2012-09-09 15:28:48 PDT
Comment on attachment 163015 [details] Patch Attachment 163015 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13805300
Comment 5 WebKit Review Bot 2012-09-10 09:16:39 PDT
Comment on attachment 163024 [details] Patch Clearing flags on attachment: 163024 Committed r128066: <http://trac.webkit.org/changeset/128066>
Comment 6 WebKit Review Bot 2012-09-10 09:16:43 PDT
All reviewed patches have been landed. Closing bug.
Comment 7 Roger Fong 2012-09-10 14:37:07 PDT
Hello, sorry I didn't check this earlier. But the patch has landed, the tests aren't failing and everything still builds, so I guess it's good :)