Summary: | AX: Update Windows port accessible role mappings to fix some tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Mazzoni <dmazzoni> | ||||||
Component: | Accessibility | Assignee: | Dominic Mazzoni <dmazzoni> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | roger_fong, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dominic Mazzoni
2012-09-09 14:58:41 PDT
I'm uploading a patch that should fix the tests. While I was at it, I tried to map a few more accessible roles on Windows - the ones that I'm reasonably confident about based on the Chromium source code. Roger, could you patch this in and see if it fixes these three tests and doesn't break anything else on Windows? Created attachment 163015 [details]
Patch
Comment on attachment 163015 [details] Patch Attachment 163015 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13805300 Created attachment 163024 [details]
Patch
Comment on attachment 163024 [details] Patch Clearing flags on attachment: 163024 Committed r128066: <http://trac.webkit.org/changeset/128066> All reviewed patches have been landed. Closing bug. Hello, sorry I didn't check this earlier. But the patch has landed, the tests aren't failing and everything still builds, so I guess it's good :) |