| Summary: | Switch to entering the sandbox directly from main(), rather than waiting for the initialization message | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mitz | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2012-09-08 23:52:05 PDT
Created attachment 163003 [details]
Patch
Comment on attachment 163003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163003&action=review > Source/WebKit2/ChangeLog:10 > + Pass a client identifier to WebProcess as an command line argument Typo: an > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:101 > + // Initialize the sandbox. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:145 > + ASSERT(clientIdentifier); We can’t make assertions about what’s passed on the command line, since that’s outside of WebKit’s control. You should replace this with error logging and, presumably, exiting with an error code. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:235 > + // Initialize the shim. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:238 > + // Initialize the sandbox. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:244 > + // Register with AX as a remote app. Extremely useless comment. Created attachment 163006 [details]
Update patch
Comment on attachment 163006 [details] Update patch Attachment 163006 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13798547 Committed r128003: <http://trac.webkit.org/changeset/128003> Sandboxing follow-up in bug 106840. |