Bug 96194

Summary: Switch to entering the sandbox directly from main(), rather than waiting for the initialization message
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update patch mitz: review+, buildbot: commit-queue-

Sam Weinig
Reported 2012-09-08 23:52:05 PDT
Switch to entering the sandbox directly from main(), rather than waiting for the intialization message
Attachments
Patch (12.60 KB, patch)
2012-09-09 11:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Update patch (12.82 KB, patch)
2012-09-09 12:46 PDT, Sam Weinig 		mitz: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-09-09 11:07:41 PDT
Created attachment 163003 [details] Patch
mitz
Comment 2 2012-09-09 11:55:40 PDT
Comment on attachment 163003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163003&action=review > Source/WebKit2/ChangeLog:10 > + Pass a client identifier to WebProcess as an command line argument Typo: an > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:101 > + // Initialize the sandbox. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:145 > + ASSERT(clientIdentifier); We can’t make assertions about what’s passed on the command line, since that’s outside of WebKit’s control. You should replace this with error logging and, presumably, exiting with an error code. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:235 > + // Initialize the shim. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:238 > + // Initialize the sandbox. Useless comment. > Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:244 > + // Register with AX as a remote app. Extremely useless comment.
Sam Weinig
Comment 3 2012-09-09 12:46:28 PDT
Created attachment 163006 [details] Update patch
Build Bot
Comment 4 2012-09-09 12:53:40 PDT
Comment on attachment 163006 [details] Update patch Attachment 163006 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13798547
Sam Weinig
Comment 5 2012-09-09 15:47:28 PDT
Committed r128003: <http://trac.webkit.org/changeset/128003>
Alexey Proskuryakov
Comment 6 2013-01-14 16:42:38 PST
Sandboxing follow-up in bug 106840.
Note You need to log in before you can comment on or make changes to this bug.