Bug 96172

Summary: Remove String::operator+=()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, dglazkov, gustavo, peter+ews, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97412    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2012-09-07 20:13:30 PDT
Remove String::operator+=()
Attachments
Patch (1.85 KB, patch)
2012-09-07 20:16 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2012-09-22 00:10 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2012-09-24 08:46 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-09-07 20:16:19 PDT
Created attachment 162936 [details] Patch
Benjamin Poulain
Comment 2 2012-09-07 20:54:54 PDT
Comment on attachment 162936 [details] Patch Looks like the GTK bot is not happy.
Patrick R. Gansterer
Comment 3 2012-09-22 00:10:20 PDT
Created attachment 165252 [details] Patch
Benjamin Poulain
Comment 4 2012-09-22 00:37:08 PDT
Comment on attachment 165252 [details] Patch r=me. Wait for the ews to cq+.
WebKit Review Bot
Comment 5 2012-09-22 00:51:24 PDT
Comment on attachment 165252 [details] Patch Attachment 165252 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13956943
Peter Beverloo (cr-android ews)
Comment 6 2012-09-22 01:10:33 PDT
Comment on attachment 165252 [details] Patch Attachment 165252 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13950953
Patrick R. Gansterer
Comment 7 2012-09-24 08:46:57 PDT
Created attachment 165391 [details] Patch
WebKit Review Bot
Comment 8 2012-09-24 17:28:32 PDT
Comment on attachment 165391 [details] Patch Clearing flags on attachment: 165391 Committed r129433: <http://trac.webkit.org/changeset/129433>
WebKit Review Bot
Comment 9 2012-09-24 17:28:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.