Bug 96124

Summary: AX: Chromium needs access to canvasHasFallbackContent
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: AccessibilityAssignee: Dominic Mazzoni <dmazzoni>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cfleizach, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dominic Mazzoni
Reported 2012-09-07 10:03:00 PDT
In WebAccessibilityObject
Attachments
Patch (5.61 KB, patch)
2012-09-07 10:39 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2012-09-07 10:39:58 PDT
Created attachment 162811 [details] Patch
WebKit Review Bot
Comment 2 2012-09-07 10:43:40 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
chris fleizach
Comment 3 2012-09-07 13:57:36 PDT
Comment on attachment 162811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162811&action=review > Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:243 > + roleString += "WithFallbackContent"; it's a little weird to modify the role string like this i might have chosen to make it "AXCanvas (With Fallback Content)" but that's a minor nit
WebKit Review Bot
Comment 4 2012-09-07 15:54:59 PDT
Comment on attachment 162811 [details] Patch Clearing flags on attachment: 162811 Committed r127931: <http://trac.webkit.org/changeset/127931>
WebKit Review Bot
Comment 5 2012-09-07 15:55:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.