Summary: | Web Inspector: only display heap size statistics for timeline records when it makes sense | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Kosyakov
2012-09-07 09:50:23 PDT
Created attachment 162803 [details]
Patch
Comment on attachment 162803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162803&action=review > Source/WebCore/English.lproj/localizedStrings.js:741 > +localizedStrings["%s (delta %s)"] = "%s (delta %s)"; I'd rather show (+xx) or (-xx) without 'delta'. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:808 > + if ((this.usedHeapSize && this.category === WebInspector.TimelinePresentationModel.categories().scripting) || this.usedHeapSizeDelta) { Should be: this.usedHeapSize && (this.category === WebInspector.TimelinePresentationModel.categories().scripting || this.usedHeapSizeDelta) Committed r128057: <http://trac.webkit.org/changeset/128057> |