Bug 96119

Summary: Web Inspector: only display heap size statistics for timeline records when it makes sense
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Andrey Kosyakov 2012-09-07 09:50:23 PDT
We used to display heap size statistics for all records. This does not seem to make much sense. Also, total heap size does not seem to be very meaningful.
Let's drop totalHeapSize and instead add usedHeapSizeDelta, as the delta between the start and stop of the event.
Comment 1 Andrey Kosyakov 2012-09-07 10:22:38 PDT
Created attachment 162803 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-10 05:43:28 PDT
Comment on attachment 162803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162803&action=review

> Source/WebCore/English.lproj/localizedStrings.js:741
> +localizedStrings["%s (delta %s)"] = "%s (delta %s)";

I'd rather show (+xx) or (-xx) without 'delta'.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:808
> +        if ((this.usedHeapSize && this.category === WebInspector.TimelinePresentationModel.categories().scripting) || this.usedHeapSizeDelta) {

Should be: this.usedHeapSize && (this.category === WebInspector.TimelinePresentationModel.categories().scripting || this.usedHeapSizeDelta)
Comment 3 Andrey Kosyakov 2012-09-10 07:02:30 PDT
Committed r128057: <http://trac.webkit.org/changeset/128057>