Bug 96082

Summary: Fix FilterTypeZoom to properly call canvas->restore()
Product: WebKit Reporter: Zachary Kuznia <zork>
Component: New BugsAssignee: Zachary Kuznia <zork>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zachary Kuznia
Reported 2012-09-07 01:18:35 PDT
Fix FilterTypeZoom to properly call canvas->restore()
Attachments
Patch (3.46 KB, patch)
2012-09-07 01:19 PDT, Zachary Kuznia
no flags
Patch (3.36 KB, patch)
2012-09-09 22:34 PDT, Zachary Kuznia
no flags
Zachary Kuznia
Comment 1 2012-09-07 01:19:58 PDT
Adrienne Walker
Comment 2 2012-09-07 09:50:47 PDT
Comment on attachment 162703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > - canvas->drawBitmap(state.source(), 0, 0); > + canvas->drawSprite(state.source(), 0, 0, &paint); Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here.
Zachary Kuznia
Comment 3 2012-09-09 22:34:36 PDT
Zachary Kuznia
Comment 4 2012-09-09 22:36:21 PDT
(In reply to comment #2) > (From update of attachment 162703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > > - canvas->drawBitmap(state.source(), 0, 0); > > + canvas->drawSprite(state.source(), 0, 0, &paint); > > Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here. Upon further investigation, it seems that "canvas->Restore()" was sufficient, so I reverted this call.
Adrienne Walker
Comment 5 2012-09-10 10:46:39 PDT
Comment on attachment 163040 [details] Patch R=me.
WebKit Review Bot
Comment 6 2012-09-11 09:44:11 PDT
Comment on attachment 163040 [details] Patch Clearing flags on attachment: 163040 Committed r128196: <http://trac.webkit.org/changeset/128196>
WebKit Review Bot
Comment 7 2012-09-11 09:44:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.