Bug 96078

Summary: [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, hausmann, ossy, vestbo, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Zoltan Arvai
Reported 2012-09-07 00:41:19 PDT
Currently QtWebKit MSVC build on Windows places JSC, DumpRenderTree, ImageDiff and QtTestBrowser to wrong directories: WebKitBuild\Release\Source\bin\jsc.exe WebKitBuild\Release\Tools\DumpRenderTree\bin\DumpRenderTree.exe WebKitBuild\Release\Tools\DumpRenderTree\bin\ImageDiff.exe WebKitBuild\Release\Tools\bin\QtTestBrowser.exe Those should land in WebKitBuild\Release\bin\
Attachments
patch (1.38 KB, patch)
2012-09-07 00:45 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2012-09-07 00:45:40 PDT
Created attachment 162694 [details] patch Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
WebKit Review Bot
Comment 2 2012-09-07 03:44:34 PDT
Comment on attachment 162694 [details] patch Clearing flags on attachment: 162694 Committed r127851: <http://trac.webkit.org/changeset/127851>
WebKit Review Bot
Comment 3 2012-09-07 03:44:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.