Summary: | [EFL][WK2] Minibrowser locks up when right clicking editable filed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||
Component: | WebKit EFL | Assignee: | Jinwoo Song <jinwoo7.song> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 95955 | ||||||
Attachments: |
|
Description
Jinwoo Song
2012-09-06 23:24:49 PDT
Created attachment 162977 [details]
patch
WebProcess crashes when the context menu type is SubmenuType and non-CROSS_PLATFORM_CONTEXT_MENUS is used.
It is because platformSubMenu() in the ContextMenuItemEfl.cpp returns null. This patch implements the setSubMenu()
and platformSubMenu() to set and return the subMenuItems.
Comment on attachment 162977 [details]
patch
Looks good to me because EFL port also uses Vector class for context menu item as chromium port.
Comment on attachment 162977 [details] patch Clearing flags on attachment: 162977 Committed r128011: <http://trac.webkit.org/changeset/128011> All reviewed patches have been landed. Closing bug. |