Bug 96071

Summary: Add *explicit* keyword to constructors in WebCore/xml
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-09-06 22:51:54 PDT
As a step to let *explicit* keyword add to constructors which have only one parameter, *explicit* keyword is added to Source/WebCore/xml in order to avoid implicit type conversion.
Attachments
Patch (7.34 KB, patch)
2012-09-06 22:53 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-09-06 22:53:50 PDT
Created attachment 162675 [details] Patch
Gyuyoung Kim
Comment 2 2012-09-06 22:54:29 PDT
This patch should pass all ews.
Gyuyoung Kim
Comment 3 2012-09-07 00:20:33 PDT
CC'ing Kentaro.
Kentaro Hara
Comment 4 2012-09-07 01:45:38 PDT
Comment on attachment 162675 [details] Patch Looks OK.
WebKit Review Bot
Comment 5 2012-09-07 04:03:45 PDT
Comment on attachment 162675 [details] Patch Clearing flags on attachment: 162675 Committed r127852: <http://trac.webkit.org/changeset/127852>
WebKit Review Bot
Comment 6 2012-09-07 04:03:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.