Bug 96071 - Add *explicit* keyword to constructors in WebCore/xml
Summary: Add *explicit* keyword to constructors in WebCore/xml
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 22:51 PDT by Gyuyoung Kim
Modified: 2012-09-07 04:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.34 KB, patch)
2012-09-06 22:53 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-09-06 22:51:54 PDT 
As a step to let *explicit* keyword add to constructors which have only one parameter, *explicit* keyword is added to Source/WebCore/xml in order to avoid implicit type conversion.
Comment 1 Gyuyoung Kim 2012-09-06 22:53:50 PDT 
Created attachment 162675 [details]
Patch
Comment 2 Gyuyoung Kim 2012-09-06 22:54:29 PDT 
This patch should pass all ews.
Comment 3 Gyuyoung Kim 2012-09-07 00:20:33 PDT 
CC'ing Kentaro.
Comment 4 Kentaro Hara 2012-09-07 01:45:38 PDT 
Comment on attachment 162675 [details]
Patch

Looks OK.
Comment 5 WebKit Review Bot 2012-09-07 04:03:45 PDT 
Comment on attachment 162675 [details]
Patch

Clearing flags on attachment: 162675

Committed r127852: <http://trac.webkit.org/changeset/127852>
Comment 6 WebKit Review Bot 2012-09-07 04:03:48 PDT 
All reviewed patches have been landed.  Closing bug.