Bug 96068

Summary: webkit.py gdb pretty printer can't print CString
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: Tools / TestsAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kenichi Ishibashi
Reported 2012-09-06 22:25:30 PDT
Due to r126191.
Attachments
Patch (1.65 KB, patch)
2012-09-06 22:29 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.65 KB, patch)
2012-09-07 19:38 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-09-06 22:29:35 PDT
Created attachment 162671 [details] Patch
Kenichi Ishibashi
Comment 2 2012-09-06 22:30:21 PDT
Hi Tony, Could you take a look?
Tony Chang
Comment 3 2012-09-07 09:53:46 PDT
Comment on attachment 162671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review > Tools/gdb/webkit.py:119 > + data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer()) Nit: I would use ' instead of " to be consistent with the code around it.
Kenichi Ishibashi
Comment 4 2012-09-07 19:38:16 PDT
Created attachment 162934 [details] Patch for landing
Kenichi Ishibashi
Comment 5 2012-09-07 19:38:39 PDT
Comment on attachment 162671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review >> Tools/gdb/webkit.py:119 >> + data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer()) > > Nit: I would use ' instead of " to be consistent with the code around it. Done. Thanks!
WebKit Review Bot
Comment 6 2012-09-08 00:35:55 PDT
Comment on attachment 162934 [details] Patch for landing Clearing flags on attachment: 162934 Committed r127965: <http://trac.webkit.org/changeset/127965>
WebKit Review Bot
Comment 7 2012-09-08 00:35:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.