Bug 96045

Summary: [JSC] Split GCActivitiyCallback.cpp into each port file
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED LATER    
Severity: Normal CC: ggaren, hausmann, laszlo.gombos, mhahnenberg, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95923    
Attachments:
Description Flags
Work-in-progress
none
WIP
none
Patch
none
Patch for win port none

Gyuyoung Kim
Reported 2012-09-06 17:42:41 PDT
There is a port specific file in each port which uses CMake except for wince port. So, I think it is better to remove GCActivityCallback.cpp in JavaScriptCore/CMakeLists.txt, then PlatformXXX.cmake file has a port specific file.
Attachments
Work-in-progress (12.80 KB, patch)
2012-12-05 22:18 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
WIP (14.25 KB, patch)
2013-01-04 00:56 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (22.26 KB, patch)
2013-01-11 00:03 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for win port (22.33 KB, patch)
2013-01-14 22:15 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-12-05 22:18:10 PST
Created attachment 177935 [details] Work-in-progress
Gyuyoung Kim
Comment 2 2013-01-04 00:56:52 PST
Created attachment 181281 [details] WIP
Build Bot
Comment 3 2013-01-04 01:39:40 PST
Comment on attachment 181281 [details] WIP Attachment 181281 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15677103
Gyuyoung Kim
Comment 4 2013-01-11 00:03:10 PST
Created attachment 182275 [details] Patch
Build Bot
Comment 5 2013-01-11 00:25:45 PST
Comment on attachment 182275 [details] Patch Attachment 182275 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15810203
Gyuyoung Kim
Comment 6 2013-01-14 22:15:08 PST
Created attachment 182703 [details] Patch for win port
Gyuyoung Kim
Comment 7 2013-01-15 02:47:09 PST
CC'ing Geoffrey and Simon, I would like get you guys comment.
Geoffrey Garen
Comment 8 2013-01-16 19:04:01 PST
The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer. I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant.
Gyuyoung Kim
Comment 9 2013-01-19 03:59:12 PST
(In reply to comment #8) > The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer. > > I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant. Ok, I will prepare new patch according to your comment. Thanks.
Gyuyoung Kim
Comment 10 2013-05-22 19:26:12 PDT
I'd like to postpone to fix this later.
Note You need to log in before you can comment on or make changes to this bug.